revert: temporarily undo Locker-specific logic @W-17769475#5198
Merged
revert: temporarily undo Locker-specific logic @W-17769475#5198
Conversation
jye-sf
approved these changes
Feb 6, 2025
jye-sf
reviewed
Feb 6, 2025
Contributor
jye-sf
left a comment
jye-sf
left a comment
There was a problem hiding this comment.
Are all the other changes in those commits not needed to be reverted?
Contributor
Author
No, they're just adding a flag. If we don't use the flag, nothing bad will happen. |
Contributor
Author
|
Oh wait, the tests tho. 🤦 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Reverts #5136 #5163.
Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?
GUS work item